Permit coBool options to be set with booleans #4668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pe enforcement for setting it with a string (only accepts "1" and "0").
|
❌ Build Slic3r 1.3.0-master-2203 failed (commit 77165a4b4d by @lordofhyphens) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coBool options weren't permitted to be set with boolean values; the only valid setter was via string "1" and "0", which is very inconvenient (and wasn't intended on the initial PR).
Additionally, booleans being set with a string are a special kind of enumeration and should be treated as such. Our configs emit "1" and "0" and should not accept "Z" or anything like that (which they were and treating as false).
Tests have been fixed/expanded.