Added Repetier FW flavor, fixed accel gcode generation for it. #3427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordofhyphens
added
the
Feature request
|
X and Y will be set to the same value because we don't differentiate in the GUI settings between the X/Y accelerations. |
|
Still needs a short test to ensure that it generates the correct gcode output in the Repetier flavor. I think the minimum test would load a default config, change the flavor to Repetier and set the accel to a distinctive value and then generate gcode. The validation would be that the number shows up in gcode and the line where it does show up is Also, |
…ation M code and that the values are set properly.
|
There, test also accounts for regression as well and passes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3426