Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unideal bridge direction #2477

Closed
vapetrov opened this issue Jan 1, 2015 · 6 comments
Closed

unideal bridge direction #2477

vapetrov opened this issue Jan 1, 2015 · 6 comments
Labels
Bridges Fixed
Milestone
1.3.0

Comments

@vapetrov
Copy link

vapetrov commented Jan 1, 2015

version 1.2.4 64 bit

model:https://www.dropbox.com/s/qxprwbjgljlvx0k/lego.stl
capture
As you can see, slic3r attempts to bridge lengthwise. Although this technically works, if the bridge direction was rotated 90 degrees, the length of the bridge would be much shorter.

Ideally, there should be an option to override bridge direction.
@harriv
Copy link
Contributor

harriv commented Jan 1, 2015

Ideally, Slic3r would automatically find the optimal solution :)

@blue-ice
Copy link

blue-ice commented Jan 2, 2015

Windows 7?

@vapetrov
Copy link
Author

vapetrov commented Jan 2, 2015

I'm getting identical results in Win 7 and XUbuntu.

@alranel
Copy link
Member

alranel commented Jan 5, 2015

Good test case. The current logic should actually suggest the other direction: Slic3r chooses the direction that has most coverage and shortest max line length - in this case both directions have equal coverage, so it shouldn't be choosing this one. However coverage of angle 0° results slightly greater because of the way it is computed.
I think I should find a more robust algorithm for computing coverage/visibility.

@alranel alranel modified the milestones: 1.2.5, 1.2.6 Jan 6, 2015
@alranel alranel modified the milestones: 1.2.6, 1.2.7 Jan 19, 2015
@alranel alranel modified the milestones: 1.3.0, 1.2.7 May 3, 2015
@alranel
Copy link
Member

alranel commented Mar 27, 2017

lego.stl.zip

alranel added a commit that referenced this issue Apr 3, 2017
@alranel
Improve bridge detection algorithm. #2477
91e7ef7
@alranel
Copy link
Member

alranel commented Apr 3, 2017

This was an excellent test case. I improved the bridge detection code and also applied one more algorithm to handle bridges covering pillars. A regression test was added to the test suite.

@alranel alranel closed this as completed Apr 3, 2017
@alranel alranel added the Fixed label Apr 3, 2017
@alranel alranel mentioned this issue Apr 5, 2017
Open
@hobsie hobsie mentioned this issue Apr 10, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bridges Fixed
Projects
None yet
Milestone
1.3.0
Development

No branches or pull requests
5 participants
@lordofhyphens @alranel @harriv @blue-ice @vapetrov