-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Allow to set shell thickness #1405
Comments
What does this solve other than porting a issue Cura has with having to warn you when it's not cleanly divisible over to Slic3r? Also, unless you fix the perimeter width there's a ton of possible combinations and no good heuristic that I can think of offhand to select the correct one. |
I tend to agree with considerations by @lordofhyphens, but I've seen that it might be useful to have this in addition to perimeters/top/bottom, defined as "Minimum Shell Thickness". Number of perimeters would be increased until that thickness is achieved, regardless of their divisibility. This option would be useful to display in the plater overrides/shortcuts. |
I'm looking into this. I've added the option in the UI and I'm working on some checks for spiral vase. |
I created a pull request for this feature |
* Added Minimum shell thickness option -Added the option to libslic3r -Created some of the necessary checks for illegal values * Enforce min_shell_thickness as 0 when spiral vase is enabled -This could be switched to match the extrusion width, but we already know there will only be 1 perimeter so this is probably more logical * Feature is implemented -Added a method in PerimeterGenerator to determine the amount of perimeters needed to meet min_shell_thickness * Added a test in perimeters.t * Fixed styling as requested -Removed the magic number in PerimeterGenerator::num_loops() -Added more test cases in perimeters.t -Added documentation of the new feature in slic3r.pl and README.md * Implemented requested changes -Removed the num_loops function from PerimeterGenerator -Added a scalled min_shell_thickness variable to PerimeterGenerator -Changed the loop_number logic to use a previously defined variable loops * Resolved more implementation issues -Added min shell to invalidate state method -Created additional checks in PresetEditor and LayerRegion for min shell -Fixed the tooltip to be more descriptive
Merged PR is incomplete; sets minimum shell only. |
Hi,
I'd would be nice to be able to set arbitrary shell thicknes instead of setting number of layers/perimentrs.
For example to set horizontal shells to 1mm and vertical shells to 1.5mm --> Number of layers/perimetrs would be calculated by slic3r automatically depending on layer and extruder properties.
The text was updated successfully, but these errors were encountered: