Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Allow to set shell thickness #1405

Closed
zdar opened this issue Aug 24, 2013 · 5 comments
Closed

Feature Request: Allow to set shell thickness #1405

zdar opened this issue Aug 24, 2013 · 5 comments
Labels
Feature request This is an idea for a new feature in Slic3r Low Effort Perimeters
Milestone

Comments

@zdar
Copy link

zdar commented Aug 24, 2013

Hi,
I'd would be nice to be able to set arbitrary shell thicknes instead of setting number of layers/perimentrs.

For example to set horizontal shells to 1mm and vertical shells to 1.5mm --> Number of layers/perimetrs would be calculated by slic3r automatically depending on layer and extruder properties.

@lordofhyphens lordofhyphens added Feature request This is an idea for a new feature in Slic3r Perimeters labels Jun 2, 2016
@lordofhyphens lordofhyphens added this to the Pull Request or Bust milestone Jun 2, 2016
@lordofhyphens
Copy link
Member

What does this solve other than porting a issue Cura has with having to warn you when it's not cleanly divisible over to Slic3r? Also, unless you fix the perimeter width there's a ton of possible combinations and no good heuristic that I can think of offhand to select the correct one.

@alranel
Copy link
Member

alranel commented Apr 5, 2017

I tend to agree with considerations by @lordofhyphens, but I've seen that it might be useful to have this in addition to perimeters/top/bottom, defined as "Minimum Shell Thickness". Number of perimeters would be increased until that thickness is achieved, regardless of their divisibility. This option would be useful to display in the plater overrides/shortcuts.

@curieos
Copy link
Contributor

curieos commented Apr 12, 2017

I'm looking into this. I've added the option in the UI and I'm working on some checks for spiral vase.

@curieos
Copy link
Contributor

curieos commented Apr 16, 2017

I created a pull request for this feature

@lordofhyphens lordofhyphens modified the milestones: 1.3.0, 1.3.1 Apr 16, 2017
@alranel alranel modified the milestones: 1.3.1, 1.3.0 May 1, 2017
lordofhyphens pushed a commit that referenced this issue May 22, 2018
* Added Minimum shell thickness option

-Added the option to libslic3r
-Created some of the necessary checks for illegal values

* Enforce min_shell_thickness as 0 when spiral vase is enabled

-This could be switched to match the extrusion width, but we already know there will only be 1 perimeter so this is probably more logical

* Feature is implemented

-Added a method in PerimeterGenerator to determine the amount of perimeters needed to meet min_shell_thickness

* Added a test in perimeters.t

* Fixed styling as requested

-Removed the magic number in PerimeterGenerator::num_loops()
-Added more test cases in perimeters.t
-Added documentation of the new feature in slic3r.pl and README.md

* Implemented requested changes

-Removed the num_loops function from PerimeterGenerator
-Added a scalled min_shell_thickness variable to PerimeterGenerator
-Changed the loop_number logic to use a previously defined variable loops

* Resolved more implementation issues

-Added min shell to invalidate state method
-Created additional checks in PresetEditor and LayerRegion for min shell
-Fixed the tooltip to be more descriptive
@lordofhyphens
Copy link
Member

Merged PR is incomplete; sets minimum shell only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request This is an idea for a new feature in Slic3r Low Effort Perimeters
Projects
None yet
Development

No branches or pull requests

4 participants