Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: ✅ adds first E2E tests #462

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Conversation

jalezi
Copy link
Collaborator

@jalezi jalezi commented Mar 4, 2024

Adds simple tests to check if html lang attr had proper value.

Library: Playwright

TODO: CI GitHub Actions; help needed :)

@jalezi jalezi requested a review from stefanb March 4, 2024 08:28
Copy link
Member

@stefanb stefanb Mar 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already running in CI, currently (until merged) only of this PR:
image
linking to log: https://github.com/sledilnik/zdravniki/actions/runs/8138501156/job/22239461278?pr=462

Did you want something more?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefanb stefanb merged commit 9a8aba0 into master Mar 5, 2024
6 checks passed
@stefanb stefanb deleted the test-jalezi/adds-first-test branch March 5, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants