Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🚑️ not fallback langs on first load redirected to 404 #461

Merged
merged 1 commit into from
Mar 3, 2024
Merged

fix: 🚑️ not fallback langs on first load redirected to 404 #461

merged 1 commit into from
Mar 3, 2024

Conversation

jalezi
Copy link
Collaborator

@jalezi jalezi commented Mar 3, 2024 •
edited
Loading

@jalezi
fix: 🚑️ not fallback langs on first load redirected to 404
7913b5c 
https://sledilnik.slack.com/archives/CV93RSH17/p1709448743246669?thread_ts=1708892539.600929&cid=CV93RSH17

Before: Our router was getting supported languages from `initOptions.fallbackLng`
After: from resource languages variable
@jalezi jalezi requested a review from stefanb March 3, 2024 14:59
@stefanb stefanb merged commit d0f4271 into master Mar 3, 2024
5 checks passed
@stefanb stefanb deleted the fix-jalezi/fallback-redirect branch March 3, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanb stefanb stefanb approved these changes

Assignees
No one assigned
Labels
deploy-preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jalezi @stefanb