Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Deployment Target to 10.0 for Carthage #2

Merged
merged 1 commit into from
Mar 14, 2019
Merged

Set Deployment Target to 10.0 for Carthage #2

merged 1 commit into from
Mar 14, 2019

Conversation

Marcocanc
Copy link
Contributor

Summary

Carthage will compile for the deployment target specified in the Xcode Project, which was set to 12.1.
This PR sets it to the required minimum deployment target of 10.0.

@CLAassistant
Copy link

CLAassistant commented Mar 14, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@TosinAF
Copy link
Contributor

TosinAF commented Mar 14, 2019

Thanks for the catch!

@TosinAF TosinAF merged commit f5379a1 into slackhq:master Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TosinAF TosinAF TosinAF approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Marcocanc @CLAassistant @TosinAF