Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows for custom tokens in place of the bot's #85

Closed
wants to merge 1 commit into from

Conversation

hjstn
Copy link

@hjstn hjstn commented Nov 6, 2015

This is useful in methods such as "chat.delete" where the user may require a token with administrative access.

@hjstn
Copy link
Author

hjstn commented Jan 26, 2016

Hey, could you guys consider this pull request?

@kesne
Copy link

kesne commented Jan 26, 2016

It might be advantageous to make a PR against the 2.0.0-beta branch.

@ghost
Copy link

ghost commented Feb 15, 2016

So, I'm not super familiar with the way that the new bot scopes work, so I'm going to ask one of the folks on our platform team to answer this PR.

My initial reaction is that there should be a safer way to do this than requiring users to give you tokens against their accounts.

@DEGoodmanWilson
Copy link

I'm going to close this, because new features like this should be focused on the 3.x branches. However, this is a good and interesting point you raise that deserves further attention. Would you be willing to open an issue for discussing it further? (I am very familiar with bot tokens, and how they are issued along side a more standard bearer token.)

@hjstn
Copy link
Author

hjstn commented Jun 26, 2016

Sure, here it is: #237

@DEGoodmanWilson
Copy link

🙇

aoberoi pushed a commit to aoberoi/node-slack-sdk that referenced this pull request Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants