Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new @slack/socket-mode package #1096

Merged
merged 14 commits into from
Jan 12, 2021
Merged

Added new @slack/socket-mode package #1096

merged 14 commits into from
Jan 12, 2021

Conversation

stevengill
Copy link
Member

Summary

Add a new package for Socket Mode. Still in progress.

Requirements (place an x in each [ ])

@gitwave gitwave bot added the untriaged label Sep 16, 2020
@stevengill stevengill changed the title Feat socket mode Added new @slack/socket-mode package Sep 16, 2020
@stevengill stevengill added enhancement M-T: A feature request for new functionality and removed untriaged labels Sep 16, 2020
@stevengill stevengill self-assigned this Sep 16, 2020
@codecov
Copy link

codecov bot commented Oct 2, 2020

Codecov Report

❗ No coverage uploaded for pull request base (next-major@d4e89b7). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             next-major    #1096   +/-   ##
=============================================
  Coverage              ?   94.35%           
=============================================
  Files                 ?       12           
  Lines                 ?      797           
  Branches              ?      177           
=============================================
  Hits                  ?      752           
  Misses                ?       15           
  Partials              ?       30           
Flag Coverage Δ
eventsapi 90.74% <0.00%> (?)
interactivemessages 94.83% <0.00%> (?)
webapi 95.59% <0.00%> (?)
webhook 87.50% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4e89b7...0de185e. Read the comment docs.

@seratch seratch mentioned this pull request Nov 12, 2020
6 tasks
@stevengill stevengill force-pushed the feat-socket-mode branch 2 times, most recently from c159234 to 2e8370c Compare December 14, 2020 21:36
@stevengill stevengill marked this pull request as ready for review December 16, 2020 00:40
Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting to see this nearing completion! 😃 I've suggested some changes to tighten up the documentation before other teammates do a more thorough review.

docs/_packages/socket_mode.md Outdated Show resolved Hide resolved
docs/_packages/socket_mode.md Outdated Show resolved Hide resolved
docs/_packages/socket_mode.md Outdated Show resolved Hide resolved
docs/_packages/socket_mode.md Outdated Show resolved Hide resolved
docs/_packages/socket_mode.md Outdated Show resolved Hide resolved
packages/socket-mode/README.md Outdated Show resolved Hide resolved
packages/socket-mode/README.md Outdated Show resolved Hide resolved
packages/socket-mode/README.md Outdated Show resolved Hide resolved
packages/socket-mode/README.md Outdated Show resolved Hide resolved
packages/socket-mode/README.md Outdated Show resolved Hide resolved
docs/_packages/socket_mode.md Outdated Show resolved Hide resolved
docs/_packages/socket_mode.md Outdated Show resolved Hide resolved
docs/_packages/socket_mode.md Outdated Show resolved Hide resolved
packages/socket-mode/src/SocketModeClient.ts Outdated Show resolved Hide resolved
packages/web-api/src/methods.ts Outdated Show resolved Hide resolved
@stevengill stevengill changed the base branch from main to next-major January 5, 2021 23:48
@stevengill stevengill added this to the next-major milestone Jan 5, 2021
@stevengill stevengill force-pushed the feat-socket-mode branch 5 times, most recently from beafe5c to f1836f6 Compare January 9, 2021 01:08
packages/socket-mode/README.md Show resolved Hide resolved
docs/_packages/socket_mode.md Outdated Show resolved Hide resolved
docs/_packages/socket_mode.md Outdated Show resolved Hide resolved
docs/_packages/socket_mode.md Outdated Show resolved Hide resolved
docs/_packages/socket_mode.md Outdated Show resolved Hide resolved
docs/_packages/socket_mode.md Show resolved Hide resolved
docs/_packages/socket_mode.md Outdated Show resolved Hide resolved
docs/_packages/socket_mode.md Outdated Show resolved Hide resolved
packages/socket-mode/README.md Outdated Show resolved Hide resolved
packages/socket-mode/README.md Show resolved Hide resolved
Co-authored-by: Shay DeWael <sdewael@slack-corp.com>
- @slack/socket-mode@0.1.0-socketModeBeta.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants