Skip to content

New option to ignore events by other workspace users in shared channels #593

Closed
@seratch

Description

@seratch

Description

When this project started, Slack was not yet providing shared channels.

It's not supposed to invite Hubot users to shared channels but it may unintentionally happen. To avoid some confusion among end-users, it would be great if this project provides an option to turn off reacting to other workspace users.

The default behavior will be the same. Developers can turn off reacting to other workspace users by configuring Hubot apps.

I've already verified seratch@3190bac works as I expect in shared channels. I will come up with a pull request with a new option named INSTALLED_TEAM_ONLY.

What type of issue is this? (place an x in one of the [ ])

  • bug
    enhancement (feature request)
    question
    documentation related
    testing related
    discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
    I've read and agree to the Code of Conduct.
    I've searched for any related issues and avoided creating a duplicate issue.

Activity

self-assigned this
on Apr 24, 2020
modified the milestones: 4.8.0, 4.8.0 on Apr 24, 2020
seratch

seratch commented on Apr 28, 2020

@seratch
ContributorAuthor

I'm a bit busy with https://github.com/slackapi/python-slackclient this week and probably next week. After finishing those Python tasks, I will make a pull request addressing this issue.

added a commit that references this issue on May 14, 2020

Fix slackapi#593 New option to ignore events by other workspace users…

932998a
added a commit that references this issue on May 18, 2020

Merge pull request #597 from seratch/issue-593-installed-team-only

3276b66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions

    New option to ignore events by other workspace users in shared channels · Issue #593 · slackapi/hubot-slack