Description

We believe that hubot-slack is calling the bots.info API excessively without caching.

We experienced a rate limit event with our Hubot today. After some investigation from Slack support, this is what they found:

According to our logs, what seems to have happened is that this bot called the bots.info API method (https://api.slack.com/methods/bots.info) at a sustained rate of 70 requests/minute for about 40 minutes.

I audited our own code and it doesn't look like we call it directly. I suspect it might be this uncached invocation in hubot-slack, which is outside our application's code:

What type of issue is this?

• bug

  enhancement (feature request)

  question

  documentation related

  testing related

  discussion
  To pick up a draggable item, press the space bar. While dragging, use the arrow keys to move the item. Press space again to drop the item in its new position, or press escape to cancel.

Requirements

• I've read and understood the Contributing guidelines and have done my best effort to follow them.

  I've read and agree to the Code of Conduct.

  I've searched for any related issues and avoided creating a duplicate issue.
  To pick up a draggable item, press the space bar. While dragging, use the arrow keys to move the item. Press space again to drop the item in its new position, or press escape to cancel.

Bug Report

Reproducible in:

hubot-slack version: Latest git master

node version: v8.2.0

OS version(s): Debian stretch

Steps to reproduce:

Unsure as of yet - because it happens outside our own code we don't know how to cause it to reproduce.

Expected result:

hubot-slack works as normal.

Actual result:

hubot-slack is rate-limited by Slack.

Attachments:

The Slack support request 2659016 may have some additional context for you.