Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a #855 bug where user_scopes exist even when user token is absent #858

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

seratch
Copy link
Member

@seratch seratch commented Mar 13, 2023

This pull request resolves a bug in #855 changes

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@seratch seratch added bug Something isn't working area:async area:sync labels Mar 13, 2023
@seratch seratch added this to the 1.17.0 milestone Mar 13, 2023
@seratch seratch self-assigned this Mar 13, 2023
@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Merging #858 (94421da) into main (a301d3a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #858   +/-   ##
=======================================
  Coverage   92.00%   92.00%           
=======================================
  Files         181      181           
  Lines        6240     6242    +2     
=======================================
+ Hits         5741     5743    +2     
  Misses        499      499           
Impacted Files Coverage Δ
slack_bolt/authorization/async_authorize.py 85.27% <100.00%> (+0.09%) ⬆️
slack_bolt/authorization/authorize.py 85.00% <100.00%> (+0.09%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@seratch seratch merged commit fbba6cd into slackapi:main Mar 13, 2023
@seratch seratch deleted the user-scopes branch March 13, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:async area:sync bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant