Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable developers to define app.message listener without args to capture all messages #848

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

seratch
Copy link
Member

@seratch seratch commented Mar 9, 2023

This pull request enhances app.message listener to capture all new messages when defining it without arguments.

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@seratch seratch added enhancement New feature or request area:async area:sync labels Mar 9, 2023
@seratch seratch added this to the 1.16.4 milestone Mar 9, 2023
@seratch seratch self-assigned this Mar 9, 2023
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #848 (3523ab1) into main (57cb043) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #848   +/-   ##
=======================================
  Coverage   92.10%   92.10%           
=======================================
  Files         181      181           
  Lines        6089     6089           
=======================================
  Hits         5608     5608           
  Misses        481      481           
Impacted Files Coverage Δ
slack_bolt/app/app.py 87.44% <ø> (ø)
slack_bolt/app/async_app.py 94.43% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@seratch seratch merged commit 36ab652 into slackapi:main Mar 10, 2023
@seratch seratch deleted the no-arg-message-listener branch March 10, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant