Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code_cov upload method #752

Merged
merged 3 commits into from
Oct 28, 2022

Conversation

WilliamBergamin
Copy link
Contributor

Bolt python is using a deprecated script for coverage in the CI pipline, this PR tried to solve this using Github actions

Category

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@WilliamBergamin WilliamBergamin added the enhancement New feature or request label Oct 27, 2022
@WilliamBergamin WilliamBergamin added this to the 1.15.3 milestone Oct 27, 2022
@WilliamBergamin WilliamBergamin self-assigned this Oct 27, 2022
removed dry_run flag and verbose flag used to test this worked
@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #752 (d6b1c29) into main (71c89cc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #752   +/-   ##
=======================================
  Coverage   92.06%   92.06%           
=======================================
  Files         172      172           
  Lines        5875     5875           
=======================================
  Hits         5409     5409           
  Misses        466      466           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for polishing the job settings!

@seratch seratch merged commit 82a98f6 into slackapi:main Oct 28, 2022
@WilliamBergamin WilliamBergamin deleted the deprecate-codecov-script branch October 28, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants