Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Sanic package to v22.x #727

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Bump Sanic package to v22.x #727

merged 1 commit into from
Sep 28, 2022

Conversation

zimeg
Copy link
Member

@zimeg zimeg commented Sep 27, 2022

To make Bolt Python compatible with the latest version of Sanic (a problem noted in #726), the versions of Sanic and Websocket were bumped to the latest supported versions for python>=3.7 while preserving the versions needed for python=3.6.

Package compatibility list

Tests

Performed with Python 3.10.6.

  • The updated package versions properly install and run an async app as expected
  • No tests fail

Category

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@zimeg zimeg added this to the 1.15.0 milestone Sep 27, 2022
@zimeg zimeg requested a review from seratch September 27, 2022 23:49
@zimeg zimeg self-assigned this Sep 27, 2022
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #727 (d19ae0c) into main (b30a319) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #727   +/-   ##
=======================================
  Coverage   92.05%   92.05%           
=======================================
  Files         172      172           
  Lines        5867     5867           
=======================================
  Hits         5401     5401           
  Misses        466      466           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Since the next release is a minor version bump, it's fine to change the oldest version to support this time.

@zimeg zimeg merged commit ffae9d2 into main Sep 28, 2022
@zimeg zimeg deleted the issue-726-bump-sanic-version branch September 28, 2022 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants