Fix #721 Passing a global dict object without channel prop can cause issues among requests #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n cause issues among requests
Codecov Report
@@ Coverage Diff @@
## main #722 +/- ##
=======================================
Coverage 92.05% 92.05%
=======================================
Files 172 172
Lines 5865 5867 +2
=======================================
+ Hits 5399 5401 +2
Misses 466 466
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
WilliamBergamin
approved these changes
Sep 20, 2022
could we have used a shallow copy?
|
@WilliamBergamin Thanks for your review! Indeed, using a shallow copy works as of today but for safety with any future changes, I prefer a deep copy this time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves #721
Category (place an
xin each of the[ ])slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements (place an
xin each[ ])Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.