Enable Flake8 in the CI builds #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seratch
added
enhancement
Codecov Report
@@ Coverage Diff @@
## main #638 +/- ##
==========================================
- Coverage 92.03% 92.03% -0.01%
==========================================
Files 170 170
Lines 5791 5789 -2
==========================================
- Hits 5330 5328 -2
Misses 461 461
Continue to review full report at Codecov.
|
filmaj
approved these changes
Apr 25, 2022
.github/workflows/flake8.yml
Outdated
| python-version: ${{ matrix.python-version }} | ||
| - name: Run pytype verification | ||
| run: | | ||
| ./scripts/run_pytype.sh |
There was a problem hiding this comment.
Still seems like we run pytype in the CI?
There was a problem hiding this comment.
Ah, yes 🤦 Thanks for catching this.
Co-authored-by: Fil Maj <maj.fil@gmail.com>
seratch
commented
Apr 25, 2022
.github/workflows/flake8.yml
Outdated
| python-version: ${{ matrix.python-version }} | ||
| - name: Run pytype verification | ||
| run: | | ||
| ./scripts/run_pytype.sh |
There was a problem hiding this comment.
Ah, yes 🤦 Thanks for catching this.
seratch
commented
Apr 25, 2022
|
@filmaj Thanks for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enables Flake8 linter in the CI builds.
Category (place an
xin each of the[ ])slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements (place an
xin each[ ])Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.