Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve oauth lambda deploy instructs #621

Merged
merged 6 commits into from
Mar 22, 2022
Merged

Improve oauth lambda deploy instructs #621

merged 6 commits into from
Mar 22, 2022

Conversation

srajiang
Copy link
Member

@srajiang srajiang commented Mar 21, 2022 •
edited
Loading

This PR updates the oauth lambda app example instructions:

  • guide users to setup narrower permissioned AWS policies
  • updates some setup steps

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • [] Document pages under /docs
  • Others examples/* changes

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • [NA] I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@srajiang srajiang added the docs Improvements or additions to documentation label Mar 21, 2022
@srajiang srajiang added this to the 1.13.1 milestone Mar 21, 2022
@srajiang srajiang self-assigned this Mar 21, 2022
@srajiang srajiang requested review from filmaj and seratch March 21, 2022 22:46
@codecov
Copy link

codecov bot commented Mar 21, 2022 •
edited
Loading

Codecov Report

Merging #621 (32ce59c) into main (8bdc43a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #621   +/-   ##
=======================================
  Coverage   92.09%   92.09%           
=======================================
  Files         170      170           
  Lines        5791     5791           
=======================================
  Hits         5333     5333           
  Misses        458      458

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bdc43a...32ce59c. Read the comment docs.

filmaj
filmaj approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton for this! Great work

seratch
seratch approved these changes Mar 22, 2022
View reviewed changes
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Added a few comments for the double-quote consistency.

examples/aws_lambda/README.md Outdated Show resolved Hide resolved
examples/aws_lambda/README.md Outdated Show resolved Hide resolved
srajiang and others added 2 commits March 21, 2022 17:01
@srajiang @seratch
Update examples/aws_lambda/README.md
75397ed 
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
@srajiang @seratch
Update examples/aws_lambda/README.md
32ce59c 
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
@seratch seratch merged commit 6c868f3 into slackapi:main Mar 22, 2022
@srajiang srajiang deleted the improve-oauth-lambda-instructs branch March 22, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forfuncsake forfuncsake forfuncsake left review comments

@filmaj filmaj filmaj approved these changes

@seratch seratch seratch approved these changes

Assignees

@srajiang srajiang

Labels
docs Improvements or additions to documentation
Projects
None yet
Milestone
1.13.1
Development

Successfully merging this pull request may close these issues.
4 participants
@srajiang @seratch @filmaj @forfuncsake