Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #542 Add additional context values for FastAPI apps #544

Merged
merged 2 commits into from
Dec 14, 2021

Conversation

seratch
Copy link
Member

@seratch seratch commented Dec 12, 2021

This pull request resolves #542 by providing a way to access the additional values as part of context objects.

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@codecov
Copy link

codecov bot commented Dec 12, 2021

Codecov Report

Merging #544 (61b4ad7) into main (e8556c1) will increase coverage by 0.01%.
The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #544      +/-   ##
==========================================
+ Coverage   91.29%   91.31%   +0.01%     
==========================================
  Files         169      169              
  Lines        5606     5616      +10     
==========================================
+ Hits         5118     5128      +10     
  Misses        488      488              
Impacted Files Coverage Δ
slack_bolt/adapter/starlette/handler.py 88.57% <90.00%> (+1.90%) ⬆️
slack_bolt/adapter/starlette/async_handler.py 88.88% <100.00%> (+1.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8556c1...61b4ad7. Read the comment docs.

@seratch seratch force-pushed the fastapi-custom-context-props branch from 010b314 to 61b4ad7 Compare December 13, 2021 02:05
@seratch seratch merged commit bc094f0 into slackapi:main Dec 14, 2021
@seratch seratch deleted the fastapi-custom-context-props branch December 14, 2021 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FastAPI: passing SQLAlchemy Session through SlackRequestHandler
1 participant