Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the Django app example to be more robust #523

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

seratch
Copy link
Member

@seratch seratch commented Nov 15, 2021

This pull request improves the Django example app to be more robust.

@paulfab
Thanks again for your input at #522

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@seratch seratch added bug Something isn't working area:examples issues related to example or sample code labels Nov 15, 2021
@seratch seratch added this to the 1.11.0 milestone Nov 15, 2021
@seratch seratch self-assigned this Nov 15, 2021
@codecov
Copy link

codecov bot commented Nov 15, 2021

Codecov Report

Merging #523 (9a36309) into main (1b5f4a1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #523   +/-   ##
=======================================
  Coverage   91.29%   91.29%           
=======================================
  Files         169      169           
  Lines        5606     5606           
=======================================
  Hits         5118     5118           
  Misses        488      488           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b5f4a1...9a36309. Read the comment docs.

@seratch seratch merged commit 068749a into slackapi:main Nov 15, 2021
@seratch seratch deleted the django-example-update branch November 15, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:examples issues related to example or sample code bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant