Fix #505 - a code snippet error in a Japanese document page #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The document of getting_started.md has not already been implemented action_button_click at this time.
|
|
seratch
changed the title
seratch
added
bug
|
Hi @TORIFUKUKaiou, thanks for submitting this PR! As this is your first contribution to @slackapi org's projects, can you check our CLA and sign it if it's fine for you? Without it, we are unable to merge your changes. Please refer to the above comment by the CLA bot. Also, for future pull requests, can you keep the following points in mind?
|
Codecov Report
@@ Coverage Diff @@
## main #507 +/- ##
=======================================
Coverage 91.43% 91.43%
=======================================
Files 167 167
Lines 5535 5535
=======================================
Hits 5061 5061
Misses 474 474 Continue to review full report at Codecov.
|
|
I sign your CLA. Thanks. |
seratch
approved these changes
Oct 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The document of getting_started.md has not already been implemented action_button_click at this time.
Fixes #505
Category (place an
xin each of the[ ])slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements (place an
xin each[ ])Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.Success: no errors found 🎉