Bump optional dependencies for v1.9.4 release #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seratch
added
enhancement
seratch
commented
Oct 29, 2021
| @@ -67,18 +67,18 @@ | |||
| "moto<2", # For AWS tests | |||
| "bottle>=0.12,<1", | |||
| "boddle>=0.2,<0.3", # For Bottle app tests | |||
| "chalice>=1.22.4,<2", | |||
| "chalice>=1.26.1,<2", | |||
There was a problem hiding this comment.
As chalice always depends on a specific version of pip (I don't know why), we want to do tests with the latest version.
seratch
commented
Oct 29, 2021
| "click>=7,<8", # for chalice | ||
| "CherryPy>=18,<19", | ||
| "Django>=3,<4", | ||
| "falcon>=2,<3", | ||
| "fastapi<1", | ||
| "fastapi>=0.70.0,<1", |
There was a problem hiding this comment.
For the consistency with starlette 0.14+
Codecov Report
@@ Coverage Diff @@
## main #504 +/- ##
=======================================
Coverage 91.43% 91.43%
=======================================
Files 167 167
Lines 5535 5535
=======================================
Hits 5061 5061
Misses 474 474 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request upgrade some of the optional dependencies. Although we do tests with these versions, older minor/patch versions of these dependencies should work with bolt-python.
Category (place an
xin each of the[ ])slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements (place an
xin each[ ])Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.