Updating lazy lambda OAuth example #444
Conversation
seratch
added
area:adapter
area:examples
|
|
||
| sys.path.insert(1, "vendor") |
There was a problem hiding this comment.
It doesn't look like this works. AWS Chalice seems to include vendor/ automatically but AWS Lambda not so much. I can't find more information on this, but I do remember before this did work! But, it has been probably 2 years or so since I've used Python in Lambda, so perhaps that behaviour has changed.
examples/aws_lambda/README.md
Outdated
| - `SLACK_INSTALLATION_S3_BUCKET_NAME`: The name of one of the S3 buckets you | ||
| created | ||
| - `SLACK_STATE_S3_BUCKET_NAME`: The name of the other S3 bucket you created | ||
| - `SLACK_LAMBDA_PATH`: ??? TODO |
There was a problem hiding this comment.
@seratch what is this env var used for, do you know?
There was a problem hiding this comment.
This is no longer needed. You can safely delete it!
examples/aws_lambda/README.md
Outdated
| - `SLACK_INSTALLATION_S3_BUCKET_NAME`: The name of one of the S3 buckets you | ||
| created | ||
| - `SLACK_STATE_S3_BUCKET_NAME`: The name of the other S3 bucket you created | ||
| - `SLACK_LAMBDA_PATH`: ??? TODO |
There was a problem hiding this comment.
This is no longer needed. You can safely delete it!
|
|
||
| sys.path.insert(1, "vendor") |
Codecov Report
@@ Coverage Diff @@
## main #444 +/- ##
=======================================
Coverage 91.34% 91.34%
=======================================
Files 167 167
Lines 5499 5499
=======================================
Hits 5023 5023
Misses 476 476 Continue to review full report at Codecov.
|
Updating the lazy lambda OAuth example with instructions
Category (place an
xin each of the[ ])slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements (place an
xin each[ ])Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.