Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added basic lazy lambda example setup and deploy instructions #442

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Aug 11, 2021

Also fixed vendor module import issues; based on the Create python package with dependencies AWS docs for Lambda, any dependencies need to exist in the root of the package. The changes in this PR are the changes I needed to incorporate to help me run the lazy example. I also tried to document my setup journey in a README in this directory.

This PR is based on trying to help out with #440.

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@filmaj filmaj requested a review from seratch August 11, 2021 20:34
@filmaj filmaj changed the title Added basic lazy lambda exmaple setup and deploy instructions Added basic lazy lambda example setup and deploy instructions Aug 11, 2021
@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #442 (6f11e8e) into main (c2f227b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #442   +/-   ##
=======================================
  Coverage   91.34%   91.34%           
=======================================
  Files         167      167           
  Lines        5499     5499           
=======================================
  Hits         5023     5023           
  Misses        476      476           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2f227b...6f11e8e. Read the comment docs.

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Having vendor directory used to work but perhaps, it's no longer compatible with the tool.

@seratch seratch added area:adapter area:examples issues related to example or sample code docs Improvements or additions to documentation labels Aug 11, 2021
@seratch seratch added this to the 1.8.0 milestone Aug 11, 2021
@seratch seratch merged commit df43450 into main Aug 11, 2021
@seratch seratch deleted the lazy-lambda-readme-fixes branch August 11, 2021 21:13
@seratch
Copy link
Member

seratch commented Aug 11, 2021

oops, I forgot to mention the OAuth example. We can update the vendor directory part for the example too. https://github.com/slackapi/bolt-python/blob/main/examples/aws_lambda/aws_lambda_oauth_config.yaml

@filmaj
Copy link
Contributor Author

filmaj commented Aug 11, 2021

Sounds good, will do

@filmaj
Copy link
Contributor Author

filmaj commented Aug 12, 2021

Opened #444

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:adapter area:examples issues related to example or sample code docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants