Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make app.shortcut compatible with Bolt for JS #40

Merged
merged 1 commit into from
Aug 25, 2020

Conversation

seratch
Copy link
Member

@seratch seratch commented Aug 24, 2020

Summary

This pull request changes the behavior of listener function registration by app.shorcut(str, regexp) to make it compatible with Bolt for JS. If a given argument is either a string or regular expression value, its generated listener matcher accepts both global and message shortcut requests.

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/run_tests.sh after making the changes.

@seratch seratch added bug Something isn't working area:async labels Aug 24, 2020
@seratch seratch added this to the 0.3.0a0 milestone Aug 24, 2020
@seratch seratch merged commit afae827 into slackapi:main Aug 25, 2020
@seratch seratch deleted the app-shorcut-compatiblity branch August 25, 2020 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:async bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant