Implement Lazy Listener Functions #34 #35
Conversation
|
|
||
| app.command(command)( | ||
| ack=respond_to_slack_within_3_seconds, | ||
| lazy=[process_request] |
There was a problem hiding this comment.
The process_request method is executed in another Lambda invocation (the same Lambda function). The duplicated request is marked as lazy_only: True and the request contains the name process_request in it.
| description: My first lambda function | ||
| runtime: python3.8 | ||
| # role: lambda_basic_execution | ||
| role: bolt_python_lambda_invocation # AWSLambdaFullAccess |
There was a problem hiding this comment.
To use lazy listener functions feature, the IAM Role should have the permission to invoke Lambda functions.
samples/lazy_async_modals_app.py
Outdated
| @@ -85,6 +89,12 @@ async def handle_command(payload, ack, respond, client, logger): | |||
| logger.info(res) | |||
|
|
|||
|
|
|||
| app.command("/hello-bolt-python")( | |||
| ack=ack_command, | |||
| lazy=[post_button_message, open_modal], | |||
There was a problem hiding this comment.
These are executed in parallel.
| await respond("Loading ...") | ||
|
|
||
|
|
||
| async def respond_5_seconds_later(respond): |
There was a problem hiding this comment.
You don't need to (and cannot) call ack() method here as it's a lazy listener function.
| @@ -15,6 +18,7 @@ def __init__(self, app: App, chalice: Chalice): | |||
| self.app = app | |||
| self.chalice = chalice | |||
| self.logger = get_bolt_app_logger(app.name, ChaliceSlackRequestHandler) | |||
| self.app.lazy_listener_runner = ChaliceLazyListenerRunner(logger=self.logger) | |||
There was a problem hiding this comment.
This code replaces the default (thread-based) one with Chalice (=Lambda framework by AWS) specific one.
| @@ -50,6 +54,15 @@ def handle(self, request: Request): | |||
| bolt_resp = oauth_flow.handle_installation(bolt_req) | |||
| return to_chalice_response(bolt_resp) | |||
| elif method == "POST": | |||
| bolt_req: BoltRequest = to_bolt_request(request, body) | |||
| # https://docs.aws.amazon.com/lambda/latest/dg/python-context.html | |||
| aws_lambda_function_name = self.chalice.lambda_context.function_name | |||
There was a problem hiding this comment.
Extracting the AWS Lambda function name for the runner#start method.
| "body": request.body, | ||
| "isBase64Encoded": False, | ||
| } | ||
| invocation = self.lambda_client.invoke( |
There was a problem hiding this comment.
Invoking the same lambda function with a modified request.
| @@ -179,6 +182,10 @@ def __init__( | |||
| self._listener_executor = ThreadPoolExecutor(max_workers=5) # TODO: shutdown | |||
| self._process_before_response = process_before_response | |||
|
|
|||
| self.lazy_listener_runner: LazyListenerRunner = ThreadLazyListenerRunner( | |||
There was a problem hiding this comment.
The default runner uses the existing thread executor.
| @@ -373,10 +424,11 @@ def event( | |||
| matchers: Optional[List[Callable[..., bool]]] = None, | |||
| middleware: Optional[List[Union[Callable, Middleware]]] = None, | |||
| ): | |||
| def __call__(func): | |||
| def __call__(*args, **kwargs): | |||
There was a problem hiding this comment.
This method accepts either of args: [ack_func, lazy_func_1, lazy_func_2] or kwargs {"ack": ack_func, "lazy": [lazy_func_1, lazy_func_2]}
|
I'll be merging this within a few days (before merging this, I will add more unit tests but don't have anything further to add in the main code). Let me know if you have any comments or feedback by then. |
Summary
This pull request adds "Lazy Listener Functions" to Bolt for Python. Please refer to #34 for details.
Category (place an
xin each of the[ ])slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapterRequirements (place an
xin each[ ])./scripts/run_tests.shafter making the changes.