Add org-level installation support #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengill
force-pushed
the
feat-org-apps
branch
from
100aaae to
a63931f
Compare
stevengill
force-pushed
the
feat-org-apps
branch
from
a63931f to
d78684f
Compare
stevengill
force-pushed
the
feat-org-apps
branch
from
304e850 to
e6c2a0d
Compare
stevengill
commented
Dec 1, 2020
| # installation_or_bot: Optional[Bot] | Optional[Installation] | ||
|
|
||
|
|
||
| # TODO |
There was a problem hiding this comment.
I haven't been able to test this yet since I can't get my local OAuth flow to work (i think my setup is messed up). Even without these changes it is hanging. I will try to sort that out but wanted to post this here so you can build upon it @seratch
Codecov Report
@@ Coverage Diff @@
## main #148 +/- ##
==========================================
- Coverage 91.79% 91.66% -0.14%
==========================================
Files 149 149
Lines 4340 4401 +61
==========================================
+ Hits 3984 4034 +50
- Misses 356 367 +11
Continue to review full report at Codecov.
|
seratch
changed the title
seratch
approved these changes
Dec 1, 2020
seratch
added a commit
to seratch/bolt-python
that referenced
this pull request
Dec 5, 2020
seratch
added a commit
to seratch/bolt-python
that referenced
this pull request
Dec 5, 2020
8 tasks
seratch
added a commit
to seratch/bolt-python
that referenced
this pull request
Dec 6, 2020
seratch
added a commit
that referenced
this pull request
Dec 8, 2020
seratch
added a commit
to seratch/bolt-python
that referenced
this pull request
Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Describe the goal of this PR. Mention any related Issue numbers)
slackapi/python-slack-sdk#877
Category (place an
xin each of the[ ])slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements (place an
xin each[ ])Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.