Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug where parsing assistant thread message event fails for beta feature enabled apps #1184

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

seratch
Copy link
Member

@seratch seratch commented Oct 22, 2024

This pull request resolves a bug where parsing assistant thread message event fails for beta feature enabled apps.

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@seratch seratch added the bug Something isn't working label Oct 22, 2024
@seratch seratch added this to the 1.21.1 milestone Oct 22, 2024
@seratch seratch self-assigned this Oct 22, 2024
@seratch seratch marked this pull request as ready for review October 22, 2024 04:08
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.92%. Comparing base (5aabb9d) to head (3c3f90c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1184   +/-   ##
=======================================
  Coverage   90.92%   90.92%           
=======================================
  Files         221      222    +1     
  Lines        7491     7495    +4     
=======================================
+ Hits         6811     6815    +4     
  Misses        680      680           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant