Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: purge the "workflow step" terminology #1124

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

WilliamBergamin
Copy link
Contributor

This PR aims to purge the workflow step terminology in favor to the new one steps from apps

Category

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@WilliamBergamin WilliamBergamin added the docs Improvements or additions to documentation label Aug 12, 2024
@WilliamBergamin WilliamBergamin added this to the 1.19.2 milestone Aug 12, 2024
@WilliamBergamin WilliamBergamin self-assigned this Aug 12, 2024
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.80%. Comparing base (b0be91a) to head (9395ff1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1124   +/-   ##
=======================================
  Coverage   91.80%   91.80%           
=======================================
  Files         186      186           
  Lines        6408     6408           
=======================================
  Hits         5883     5883           
  Misses        525      525           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one typo fix suggestion

docs/content/steps/steps.md Outdated Show resolved Hide resolved
Co-authored-by: Fil Maj <maj.fil@gmail.com>
@WilliamBergamin WilliamBergamin merged commit fbd6462 into main Aug 12, 2024
14 checks passed
@WilliamBergamin WilliamBergamin deleted the adhere-to-terminology branch August 12, 2024 21:20
@WilliamBergamin WilliamBergamin modified the milestones: 1.19.2, 1.20.0 Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants