feat: add WSGI adapter #1085
feat: add WSGI adapter #1085
Conversation
|
Can you check the flake8 errors? https://github.com/slackapi/bolt-python/actions/runs/9228875341/job/25393855815?pr=1085 |
slack_bolt/adapter/wsgi/utils.py
Outdated
| @@ -0,0 +1 @@ | |||
| ENCODING = "utf-8" # should always be utf-8 | |||
There was a problem hiding this comment.
This is fine for Slack apps but perhaps the comment should be clearer to clarify we understand this is not true for WSGI in general:
| ENCODING = "utf-8" # should always be utf-8 | |
| ENCODING = "utf-8" # The content encoding for Slack requests/responses is always utf-8 |
There was a problem hiding this comment.
Do you think it's good to rename this file to "intenrals.py" for consistency with other source files in this project?
There was a problem hiding this comment.
Renamed the file to internals.py and updated the comment 💯
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1085 +/- ##
=======================================
Coverage 91.76% 91.76%
=======================================
Files 181 186 +5
Lines 6315 6403 +88
=======================================
+ Hits 5795 5876 +81
- Misses 520 527 +7 ☔ View full report in Codecov by Sentry. |
| name = key.lower().replace("_", "-") | ||
| headers[name] = value | ||
| if key.startswith("HTTP_"): | ||
| name = key[len("HTTP_"):].lower().replace("_", "-") # fmt: skip |
There was a problem hiding this comment.
Turns out the black formatter was cause the Flake8 issue, the workaround if to add # fmt: skip on the line causing the issue
There was a problem hiding this comment.
The Black Formatter will add a whitespace between len("HTTP_") and :, Flake8 does not align with this syntax, the Black Formatter does not allow ignoring specific rules
key[len("HTTP_") :].lower().replace("_", "-")
There was a problem hiding this comment.
this makes sense; thanks for clarifying it
| name = key.lower().replace("_", "-") | ||
| headers[name] = value | ||
| if key.startswith("HTTP_"): | ||
| name = key[len("HTTP_"):].lower().replace("_", "-") # fmt: skip |
There was a problem hiding this comment.
this makes sense; thanks for clarifying it
This PR introduced a WSGI adapter to bolt python, this will allow Bolt to be deployed in production without the need for an other WSGI compatible Web Framework like Flask
Testing
examples/wsgi/app.pyas starting point for a test appscripts/build_pypi_package.sh.whlfile found underdist/to runpip install /path/to/dist/slack_bolt.whlpip install gunicorngunicorn app:api -b 0.0.0.0:3000 --log-level debugto start the applicationCategory
slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.