Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQLAlchemy example for async_find_bot out of date #747

Closed
ntarora opened this issue Oct 23, 2022 · 0 comments
Closed

SQLAlchemy example for async_find_bot out of date #747

ntarora opened this issue Oct 23, 2022 · 0 comments
Assignees
@seratch
Labels
area:async area:examples issues related to example or sample code docs Improvements or additions to documentation
Milestone
1.15.3

Comments

@ntarora
Copy link
Contributor

ntarora commented Oct 23, 2022

bolt-python/examples/sqlalchemy/async_oauth_app.py

Line 66 in 71c89cc

async def async_find_bot(self, *, enterprise_id: Optional[str], team_id: Optional[str]) -> Optional[Bot]:

The function is missing is_enterprise_install as a parameter. Submitting a PR,
@ntarora ntarora mentioned this issue Oct 23, 2022
Closed
@seratch seratch self-assigned this Oct 24, 2022
@seratch seratch added docs Improvements or additions to documentation area:async area:examples issues related to example or sample code labels Oct 24, 2022
@seratch seratch added this to the 1.15.3 milestone Oct 24, 2022
@seratch seratch closed this as completed in f5b40c7 Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seratch seratch

Labels
area:async area:examples issues related to example or sample code docs Improvements or additions to documentation
Projects
None yet
Milestone
1.15.3
Development

Successfully merging a pull request may close this issue.

Fix #747 by updating async SQLAlchemy OAuth example code ntarora/bolt-python
2 participants
@seratch @ntarora