Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete action_button_click(body, ack, say) in Japanese on docs/_tutorials/ja_getting_started.md . #505

Closed
TORIFUKUKaiou opened this issue Oct 30, 2021 · 1 comment · Fixed by #507
Closed

delete action_button_click(body, ack, say) in Japanese on docs/_tutorials/ja_getting_started.md . #505

TORIFUKUKaiou opened this issue Oct 30, 2021 · 1 comment · Fixed by #507
Labels
docs Improvements or additions to documentation
Milestone
1.10.0

Comments

@TORIFUKUKaiou
Copy link
Contributor

delete action_button_click(body, ack, say) in Japanese on docs/_tutorials/ja_getting_started.md .
The document of getting_started.md has not already been implemented action_button_click at this time.

The page URLs

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
@seratch seratch added bug Something isn't working docs Improvements or additions to documentation labels Oct 30, 2021
@seratch seratch added this to the 1.9.5 milestone Oct 30, 2021
@seratch
Copy link
Member

seratch commented Oct 30, 2021

Hi @TORIFUKUKaiou, thank you for taking the time to report this issue. And you're right. The part https://github.com/slackapi/bolt-python/blame/v1.9.4/docs/_tutorials/ja_getting_started.md#L231-L236 should be removed. If you don't mind use your time a little more, your pull request for fixing this would be appreciated.

@seratch seratch mentioned this issue Oct 30, 2021
Merged
8 tasks
@seratch seratch removed the bug Something isn't working label Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Improvements or additions to documentation
Projects
None yet
Milestone
1.10.0
Development

Successfully merging a pull request may close this issue.

Fix #505 - a code snippet error in a Japanese document page TORIFUKUKaiou/bolt-python
2 participants
@seratch @TORIFUKUKaiou