Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add global error handler #31

Closed
4 of 5 tasks
seratch opened this issue Aug 5, 2020 · 0 comments · Fixed by #43
Closed
4 of 5 tasks

Add global error handler #31

seratch opened this issue Aug 5, 2020 · 0 comments · Fixed by #43
Labels
enhancement New feature or request
Milestone
0.3.0a0

Comments

@seratch
Copy link
Member

seratch commented Aug 5, 2020

Description

As with other Bolt frameworks, the error handler should be customizable.

bolt-python/slack_bolt/app/app.py

Lines 321 to 324 in 3eea0c4

# TODO: error handler
self._framework_logger.exception(
f"Failed to run listener function (error: {e})"
)

bolt-python/slack_bolt/app/async_app.py

Lines 352 to 355 in 3eea0c4

# TODO: error handler
self._framework_logger.exception(
f"Failed to run listener function (error: {e})"
)

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter

Requirements (place an x in each of the [ ])

  • [x I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue here.
@seratch seratch added the enhancement New feature or request label Aug 5, 2020
@seratch seratch added this to the 0.3.0a1 milestone Aug 5, 2020
seratch added a commit to seratch/bolt-python that referenced this issue Aug 25, 2020
@seratch
Fix slackapi#31 by adding app.error handler
0bcf998
@seratch seratch mentioned this issue Aug 25, 2020
Merged
6 tasks
seratch added a commit that referenced this issue Aug 26, 2020
@seratch
Fix #31 by adding app.error handler (#43)
dd855e1
@WilliamBergamin WilliamBergamin mentioned this issue Aug 30, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.3.0a0
Development

Successfully merging a pull request may close this issue.

Fix #31 by adding app.error handler seratch/bolt-python
1 participant
@seratch