Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding SocketModeReceiver to Bolt-js #630

Merged
merged 10 commits into from
Jan 12, 2021
Merged

Adding SocketModeReceiver to Bolt-js #630

merged 10 commits into from
Jan 12, 2021

Conversation

stevengill
Copy link
Member

Summary

In progress! Adding new receiver for socket-mode to bolt-js

Requirements (place an x in each [ ])

@stevengill stevengill added the enhancement M-T: A feature request for new functionality label Sep 16, 2020
@stevengill stevengill self-assigned this Sep 16, 2020
@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #630 (ea3b645) into v3 (4fe9345) will decrease coverage by 6.22%.
The diff coverage is 23.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v3     #630      +/-   ##
==========================================
- Coverage   83.13%   76.91%   -6.23%     
==========================================
  Files           8        9       +1     
  Lines         765      849      +84     
  Branches      230      263      +33     
==========================================
+ Hits          636      653      +17     
- Misses         85      146      +61     
- Partials       44       50       +6     
Impacted Files Coverage Δ
src/SocketModeReceiver.ts 9.09% <9.09%> (ø)
src/App.ts 80.90% <33.33%> (-4.34%) ⬇️
src/ExpressReceiver.ts 66.66% <100.00%> (+1.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fe9345...ea3b645. Read the comment docs.

@misscoded misscoded added the draft A pull request that is currently in active development and not yet ready for review label Oct 5, 2020
@seratch seratch mentioned this pull request Nov 12, 2020
6 tasks
@stevengill stevengill force-pushed the feat-socket-mode branch 2 times, most recently from c833f14 to 1b921ed Compare December 15, 2020 18:27
@stevengill stevengill marked this pull request as ready for review December 16, 2020 00:40
@stevengill
Copy link
Member Author

screenshot of the docs

Screen Shot 2020-12-15 at 4 46 45 PM

@stevengill
Copy link
Member Author

stevengill commented Dec 16, 2020

TODO:

  • add example app
  • add tests
  • Publish new beta releases so tests pass

src/App.ts Outdated Show resolved Hide resolved
src/SocketModeReceiver.ts Outdated Show resolved Hide resolved
src/SocketModeReceiver.ts Outdated Show resolved Hide resolved
@stevengill stevengill changed the base branch from main to v3 January 5, 2021 22:50
@aoberoi aoberoi removed the draft A pull request that is currently in active development and not yet ready for review label Jan 5, 2021
@stevengill stevengill added this to the v3.0 milestone Jan 5, 2021
docs/_basic/socket_mode.md Outdated Show resolved Hide resolved
@stevengill stevengill force-pushed the feat-socket-mode branch 4 times, most recently from dd9b6d7 to 65274df Compare January 9, 2021 01:19
docs/_basic/socket_mode.md Outdated Show resolved Hide resolved
docs/_basic/socket_mode.md Outdated Show resolved Hide resolved
docs/_basic/socket_mode.md Outdated Show resolved Hide resolved
examples/socket-mode/README.md Outdated Show resolved Hide resolved
examples/socket-mode/README.md Outdated Show resolved Hide resolved
examples/socket-mode/README.md Outdated Show resolved Hide resolved
examples/socket-mode/README.md Outdated Show resolved Hide resolved
examples/socket-mode/README.md Outdated Show resolved Hide resolved
examples/socket-mode/README.md Outdated Show resolved Hide resolved
examples/socket-mode/README.md Outdated Show resolved Hide resolved
@stevengill
Copy link
Member Author

Tests are expected to fail right now due to us needing a new release of @socket-mode package

stevengill and others added 2 commits January 11, 2021 23:31
Co-authored-by: Shay DeWael <sdewael@slack-corp.com>
@stevengill stevengill merged commit eabe70d into v3 Jan 12, 2021
@stevengill stevengill deleted the feat-socket-mode branch January 12, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants