Provide default value when actions are missing in payload #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for late reply. #### 0.3.1 (Next)
* [#9](https://github.com/slack-ruby/slack-ruby-bot-server-events/pull/9): Provide default value when actions key is missing in payload - [@nijave](https://github.com/nijave).
* Your contribution here.
#### 0.3.0 (12/30/2020)
|
crazyoptimist
requested changes
Jan 29, 2021
|
This needs a test, please. |
|
Could you add a test @nijave ? |
nijave
changed the title
dblock
reviewed
Feb 1, 2021
nijave
force-pushed
the
nv-actions-default-value
branch
from
fbe9634 to
97ba16c
Compare
|
@nijave I won't merge without a spec, please add. |
nijave
force-pushed
the
nv-actions-default-value
branch
from
97ba16c to
dff37ba
Compare
dblock
requested changes
Feb 3, 2021
| @@ -48,6 +48,19 @@ | |||
| end | |||
| end | |||
|
|
|||
| context 'without actions in the payload' do | |||
| before do | |||
| payload.delete(:actions) | |||
There was a problem hiding this comment.
Take actions out of the payload above, and merge(actions: ...) in the existing spec, then you don't have to delete it here, which seems backwards.
| post '/api/slack/action', payload: payload.to_json | ||
| expect(last_response.status).to eq 201 | ||
| response = JSON.parse(last_response.body) | ||
| expect(response).to eq('text' => 'message_action: type match') |
There was a problem hiding this comment.
You need a spec that does an action, otherwise this is failing predictably to return any data.
nijave
force-pushed
the
nv-actions-default-value
branch
from
dff37ba to
2ebb6e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #8