Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix actions endpoint for block dropdowns #10

Merged
merged 4 commits into from
Mar 21, 2022

Conversation

maths22
Copy link
Contributor

@maths22 maths22 commented Mar 15, 2021

Make it so you can use this library for interactive dropdowns. Those callbacks don't have a response url, so make it optional.

@dangerpr-bot
Copy link

dangerpr-bot commented Mar 15, 2021

1 Error
🚫 Please put back the * Your contribution here. line into CHANGELOG.md.
1 Warning
⚠️ There’re library changes, but not tests. That’s OK as long as you’re refactoring existing code.

Generated by 🚫 danger

@dblock
Copy link
Contributor

dblock commented Mar 16, 2021

Thanks, care to put this in CHANGELOG please, and maybe write a quick test with an actual payload?

Copy link
Contributor

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needs tests.

@@ -2,7 +2,7 @@

#### 0.3.2 (Next)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put back this line.

@dblock
Copy link
Contributor

dblock commented Feb 28, 2022

Want to finish this @maths22 ?

@maths22
Copy link
Contributor Author

maths22 commented Feb 28, 2022

Whoops, I forgot about this; will add tests

@maths22
Copy link
Contributor Author

maths22 commented Feb 28, 2022

@dblock done and confirmed it passes locally; travis doesn't seem to be running to validate it there

@dblock
Copy link
Contributor

dblock commented Feb 28, 2022

It's cause this:

Screen Shot 2022-02-28 at 6 07 38 PM

We'll have to migrate this project to GHA, maybe someone (you?) could take care of it.

@crazyoptimist
Copy link
Collaborator

crazyoptimist commented Mar 21, 2022

@maths22 now you can merge master into your branch then CI will pass.

@maths22
Copy link
Contributor Author

maths22 commented Mar 21, 2022

Ok it should be ready to run tests once you approve running them

@crazyoptimist
Copy link
Collaborator

crazyoptimist commented Mar 21, 2022

@dblock danger is failing with this message:

Missing ENV['DATABASE_ADAPTER'].
Could not find the type of CI for Danger to run on.

Have you experienced the same? Please gimme some hints if yes.
I will investigate it and commit on the next PR(mongo v5 one).

@crazyoptimist crazyoptimist requested a review from dblock March 21, 2022 15:57
@dblock
Copy link
Contributor

dblock commented Mar 21, 2022

@crazyoptimist I don't quite understand why this happens, but it looks like adding a checkout depth of 0 fixes the problem on other repos? Copy the rest of https://github.com/slack-ruby/slack-ruby-bot-server/blob/master/.github/workflows/danger.yml#L10

@dblock dblock merged commit bdf4d21 into slack-ruby:master Mar 21, 2022
@dblock
Copy link
Contributor

dblock commented Mar 21, 2022

I merged this, care to PR an update to that dangerfile @crazyoptimist and let's see if that happens with the change?

@crazyoptimist
Copy link
Collaborator

Roger!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants