-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix actions endpoint for block dropdowns #10
Conversation
Generated by 🚫 danger |
Thanks, care to put this in CHANGELOG please, and maybe write a quick test with an actual payload? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still needs tests.
@@ -2,7 +2,7 @@ | |||
|
|||
#### 0.3.2 (Next) | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put back this line.
Want to finish this @maths22 ? |
Whoops, I forgot about this; will add tests |
@dblock done and confirmed it passes locally; travis doesn't seem to be running to validate it there |
@maths22 now you can merge |
Ok it should be ready to run tests once you approve running them |
@dblock
Have you experienced the same? Please gimme some hints if yes. |
@crazyoptimist I don't quite understand why this happens, but it looks like adding a checkout depth of 0 fixes the problem on other repos? Copy the rest of https://github.com/slack-ruby/slack-ruby-bot-server/blob/master/.github/workflows/danger.yml#L10 |
I merged this, care to PR an update to that dangerfile @crazyoptimist and let's see if that happens with the change? |
Roger! |
Make it so you can use this library for interactive dropdowns. Those callbacks don't have a response url, so make it optional.