Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor galaxy photometry from kcorrect templates #386

Merged
merged 22 commits into from
Jan 19, 2021
Merged

Refactor galaxy photometry from kcorrect templates #386

merged 22 commits into from
Jan 19, 2021

Conversation

rrjbca
Copy link
Contributor

@rrjbca rrjbca commented Dec 1, 2020 •
edited
Loading

Description

Refactor galaxy photometry using kcorrect templates into a single function for convenience. Possibly also provide a pattern for supporting other template sets in the future.

Checklist

  • Follow the Contributor Guidelines
  • Write unit tests
  • Write documentation strings
  • Assign someone from your working team to review this pull request
  • Assign someone from the infrastructure team to review this pull request

@rrjbca rrjbca added enhancement Improvement of existing feature module: galaxies labels Dec 1, 2020
@rrjbca rrjbca added this to the Version 0.4 milestone Dec 1, 2020
@rrjbca rrjbca requested review from a team December 1, 2020 15:00
@rrjbca rrjbca marked this pull request as ready for review January 18, 2021 14:12
@rrjbca rrjbca requested a review from ntessore January 18, 2021 14:12
itrharrison
itrharrison previously approved these changes Jan 19, 2021
View reviewed changes
skypy/galaxy/spectrum.py Outdated Show resolved Hide resolved
skypy/galaxy/spectrum.py Outdated Show resolved Hide resolved
ntessore
ntessore approved these changes Jan 19, 2021
View reviewed changes
Copy link
Member

@ntessore ntessore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@rrjbca rrjbca merged commit 5a1ce57 into skypyproject:master Jan 19, 2021
@rrjbca rrjbca deleted the kcorrect branch January 19, 2021 14:57
@ntessore ntessore mentioned this pull request Jan 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntessore ntessore ntessore approved these changes

@itrharrison itrharrison itrharrison left review comments

Assignees
No one assigned
Labels
enhancement Improvement of existing feature module: galaxies
Projects
None yet
Milestone
Version 0.4
Development

Successfully merging this pull request may close these issues.
3 participants
@rrjbca @itrharrison @ntessore