[k8s] Allow spot instances on supported k8s clusters #3675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelvll
reviewed
Jun 19, 2024
Michaelvll
approved these changes
Jun 19, 2024
Michaelvll
pushed a commit
that referenced
this pull request
Aug 23, 2024
* Add spot support * comment * patch get_spot_label for tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3667.
Adds support for using spot instances with
--use-spotif the underlying cluster supports spot instances.This is supported only for GKE to start and is enabled only if the cluster already has spot instances or the user has set
autoscaler: gkein config.yaml.Tested (run the relevant ones):
bash format.shsky launch --use-spoton GKE cluster with spot instancessky launch --use-spoton GKE autoscaling cluster