Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SkyServe] Add smoke test for load balancer #2911

Merged
merged 3 commits into from
Dec 28, 2023
Merged

[SkyServe] Add smoke test for load balancer #2911

merged 3 commits into from
Dec 28, 2023

Conversation

MaoZiming
Copy link
Collaborator

@MaoZiming MaoZiming commented Dec 28, 2023 •
edited
Loading

#2878 (comment)

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • pytest tests/test_smoke.py::test_skyserve_load_balancer

@MaoZiming MaoZiming requested a review from cblmemo December 28, 2023 03:09
cblmemo
cblmemo approved these changes Dec 28, 2023
View reviewed changes
Copy link
Collaborator

@cblmemo cblmemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/skyserve/load_balancer/service.yaml Show resolved Hide resolved
tests/skyserve/load_balancer/test_round_robin.py Show resolved Hide resolved
@MaoZiming MaoZiming merged commit dc543b7 into master Dec 28, 2023
19 checks passed
@MaoZiming MaoZiming deleted the load-balancer-smoke branch December 28, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cblmemo cblmemo cblmemo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaoZiming @cblmemo