Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] sky managed storages being deleted when smoke test for stroage ran #2258

Closed
landscapepainter opened this issue Jul 17, 2023 · 0 comments · Fixed by #2259
Closed

Comments

@landscapepainter
Copy link
Collaborator

landscapepainter commented Jul 17, 2023

Currently, running a smoke test for storage with pytest tests/test_smoke.py::TestStorageWithCredentials deletes all the sky managed storages created before runinng the test. This is due to subprocess.check_output(['sky', 'storage', 'delete', '-a']) ran from test_multiple_buckets_creation_and_deletion. This needs to be fixed so running the smoke test does not remove any other sky managed storages.

This can be reproduced by:

  1. Create s3 storage with sky launch task.yaml
  2. run pytest tests/test_smoke.py::TestStorageWithCredentials
  3. confirm all the storage created from 1. gets deleted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant