it is nice to have some tests and squash the commits.

add to whitelist

run skydive-python-tests

@ofirZelig Thank you for this. Could you please also add support for deletion ?

Please add some tests, it would be easy to validate the code.

Can one of the admin review this patch ?

@ofirZelig - please squash the commits - for that you can use:

git rebase -i HEAD~10

and then place an "s" command on each but your first commit. and then doing so please provide a concise commit message

@ofirZelig - please extend the description of what this PR does; and why

@ofirZelig - to test your code please use: https://docs.python.org/3/library/unittest.html

the tests should be wrapped by a script which can be invoked via CI:

scripts/ci/run-python-api-tests.sh

if you need any setup run before running these tests - then implement it in:

scripts/ci/install-<XXX>.sh

and as a development environment please use a devmode VM which can be setup as explained here:

http://skydive.network/documentation/contribute#development-box

Hi @hunchback ,

We are trying to deploy the development environment on ubuntu 18.04 using virtualbox 5.2.18 and vagrant 2.1.1. The problem is that the files sharing between the guest and the host doesnt work. We cant find the source code inside the guest so we cant build it.

Can you think of any explanation or solution for this?

@hunchback
update: We have cloned the repository to our machine but when building it we recieve the following error message:

[vagrant@dev skydive]$ make
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
LANGUAGE = (unset),
LC_ALL = (unset),
LC_MEASUREMENT = "he_IL.UTF-8",
LC_PAPER = "he_IL.UTF-8",
LC_MONETARY = "he_IL.UTF-8",
LC_NAME = "he_IL.UTF-8",
LC_ADDRESS = "he_IL.UTF-8",
LC_NUMERIC = "he_IL.UTF-8",
LC_TELEPHONE = "he_IL.UTF-8",
LC_IDENTIFICATION = "he_IL.UTF-8",
LC_TIME = "he_IL.UTF-8",
LANG = "en_US.UTF-8"
are supported and installed on your system.
perl: warning: Falling back to a fallback locale ("en_US.UTF-8").
CC= GOARCH= go get github.com/kardianos/govendor
/home/vagrant/bin/govendor sync
patch -p0 < dpdk/dpdk.govendor.patch
patching file vendor/github.com/intel-go/yanff/low/low.go
rm -rf vendor/github.com/weaveworks/tcptracer-bpf/vendor/github.com/
mv /home/vagrant/.skydive-build-tool bin || true; ln -s vendor src || mv vendor src; cd src/gopkg.in/src-d/proteus.v1/cli/proteus; (unset GOARCH; unset CC; GOPATH=$GOPATH/src/github.com/skydive-project/skydive go install gopkg.in/src-d/proteus.v1/cli/proteus); cd -; mv bin /home/vagrant/.skydive-build-tool; unlink src || mv src vendor; proteus proto -f ${GOPATH}/src -p github.com/skydive-project/skydive/flow/layers
/home/vagrant/src/github.com/skydive-project/skydive
error scanning package "github.com/skydive-project/skydive/flow/layers": /home/vagrant/src/github.com/skydive-project/skydive/flow/layers/layers.go:25:8: could not import github.com/google/gopacket/layers (/home/vagrant/src/github.com/skydive-project/skydive/vendor/github.com/google/gopacket/layers/arp.go:11:2: could not import encoding/binary (/home/vagrant/.gimme/versions/go1.9.1.linux.amd64/src/encoding/binary/binary.go:26:2: could not import io (/home/vagrant/.gimme/versions/go1.9.1.linux.amd64/src/io/pipe.go:12:2: could not import sync (/home/vagrant/.gimme/versions/go1.9.1.linux.amd64/src/sync/cond.go:8:2: could not import sync/atomic (/home/vagrant/.gimme/versions/go1.9.1.linux.amd64/src/sync/atomic/value.go:31:37: cannot convert v (variable of type *Value) to /home/vagrant/.gimme/versions/go1.9.1.linux.amd64/src/unsafe.Pointer)))))
make: *** [Makefile:233: flow/layers/generated.proto] Error 1

Install by hand is pretty simple, you could try this:
http://skydive.network/documentation/build

@ofirZelig It seems your GOPATH is /home/vagrant. Therefore, your GOROOT is inside GOPATH which is known to cause problems. We updated the Vagrant box in this commit 9bb05e8
So you may want to use a newer version of the Vagrant box.

@ofirZelig - I recommend that you use our standard test/development environment which can be deployed on your laptop/host by following:

http://skydive.network/documentation/contribute#development-box

Once done I can provide additional details on running the specific tests you have.

@safchain I'm currently working on adding InjectionRule to rules.py, but it is not clear which fileds are optional in the injection. Can you say which is optional from the following fields:
uuid, src, dst, srcip, dstip ,srcmac, dstmac, srcport, dstport, type, payload, trackingid, icmpid, count, interval, increment, starttime

Thank you

@safchain
We fixed all the changes which were requested in this PR, and squashed the commits.
The only problem is that in the automatic tests we need to create nodes but they are not able to inject. We are currently trying to solve the problem, do you have an idea what is the best way to get nodes that are able to inject?

• note: The tests we created which are not automated pass successfully

@ofirZelig maybe the loopback interface as source and destination

@safchain Is there progress in our PR?

@ofirZelig there are multiple coding style issue to fix, please have a look at the CI result

run skydive-python-tests

run skydive-python-tests

@ofirZelig why did you reverted this one 3b51fa0
? we need to use the allinone mode otherwise it fails

@ofirZelig why did you reverted this one 3b51fa0
? we need to use the allinone mode otherwise it fails

@safchain
The ssl tests fail when using "allinone" instead of "analyzer", even the tests we did not touch, do you know what is the reason? Meanwhile we tried a new approach.

@ofirZelig I'm checking why with TLS it is not working

@ofirZelig I submitted this #1621 to fix the TLS issue

@safchain
I pushed a new version of the tests, hopfully now they would pass.

@ofirZelig can you please rebase on top of master

run skydive-python-tests

@ofirZelig can you please rebase on top of master

Fixed the message, and as I understood, squashing the commits is much easier after the PR is accepted

@ofirZelig you need to rebase on top of master as we just merged the patch that fixes the TLS/allinone issue otherwise the tests won't pass

@safchain
Merged with the current master, everything should be updated

run skydive-python-tests

@safchain
Still the test cant find a node with eth0, even though we merged your commit

@ofirZelig can you apply this https://paste.fedoraproject.org/paste/naOHo3~ylIlW5B-x9HfTJQ

Please squash it if it passes I'll merge it. Thanks

run skydive-python-tests