Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues 40 and 42 - Improve open() message, make list() and dict() work. #44

Merged
merged 2 commits into from
Jan 26, 2013

Conversation

csev
Copy link
Contributor

@csev csev commented Jan 25, 2013

These are both pretty simple.

csev added 2 commits January 24, 2013 18:08
Make list() and dict() work as zero parameter constructors
Make the error message in the browser more meaningful when the
file (i.e. div) cannot be openned.

There is no unit test because it is browser-only code.

During unit tests, open() calls turn into Sk.read() which handles missing
files properly already.
bnmnetp added a commit that referenced this pull request Jan 26, 2013
Issues 40 and 42 - Improve open() message, make list() and dict() work.
@bnmnetp bnmnetp merged commit f532aaa into skulpt:master Jan 26, 2013
albertjan pushed a commit that referenced this pull request Aug 9, 2017
With, finally, py3 tests, kwargs for dict() - take 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants