Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make quit() and exit() work #36

Closed
csev opened this issue Jan 23, 2013 · 2 comments
Closed

Make quit() and exit() work #36

csev opened this issue Jan 23, 2013 · 2 comments

Comments

@csev
Copy link
Contributor

csev commented Jan 23, 2013

This is Issue 115 in Google Code

print "Hi"
if 1 < 10:
quit()
print "There"
csev added a commit to csev/skulpt that referenced this issue Jan 23, 2013
@csev
Make quit() and exit() work Issue skulpt#36
cf84bbc 
This is Issue 115 in the Google Code repo

I did this as a language change making quit() and exit() flow
statements.

I added a unit test which nicely tests functionality and passes
but the parser and symbol table unit tests are unhappy.   Either
this is a problem in my version of Python or I missed some detail
on a step I needed to take other than regentests after adding a
new unit test.  Thanks in advance for any help/explanation here.
@csev
Copy link
Contributor Author

csev commented Jan 24, 2013

This is fixed in https://github.com/bnmnetp/skulpt/pull/39

@bnmnetp
Copy link
Contributor

bnmnetp commented Jan 24, 2013

I'm not sure why you are getting the symtab and trans errors. I'm also not sure how much I care... I care more about how it runs than if it generates the exact same symbol table as python2.6. I think we would have to dig into the CPython source to figure out for sure, but I wonder if this is part of the issue.

Python 2.6.7 (r267:88850, Jun 20 2012, 16:23:38) 
[GCC 4.2.1 Compatible Apple Clang 4.0 (tags/Apple/clang-418.0.60)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
 >>> type(exit)
<class 'site.Quitter'>

both exit and quit are not really statements.

@bnmnetp bnmnetp closed this as completed Jan 24, 2013
rixner pushed a commit to rixner/skulpt that referenced this issue Jul 23, 2013
@mariechatfield
Revert "Make quit() and exit() work Issue skulpt#36"
379b6c6 
This reverts commit cf84bbc.
albertjan pushed a commit to albertjan/skulpt that referenced this issue Jun 27, 2017
@brianpmarks
Merge pull request skulpt#36 from trinketapp/promise-epiphany
530ec78 
Promise epiphany
acbart pushed a commit to RealTimeWeb/skulpt that referenced this issue Jun 20, 2018
@NeilFraser
Merge pull request skulpt#36 from carlosperate/master
bd6b80e 
Fixes google/blockly#35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bnmnetp @csev