Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] BinarySegmentation fixes for new detection interface #7504

Merged
merged 5 commits into from
Dec 29, 2024

Conversation

Alex-JG3
Copy link
Contributor

@Alex-JG3 Alex-JG3 commented Dec 9, 2024

Reference Issues/PRs

Fixes #7411.

What does this implement/fix? Explain your changes.

Removes binary segmentation tests from the exclude list so they now run are part of the CI/CD pipeline. #7476 solved most of the failing tests, and this PR fixes the remaining ones.

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I run check_estimator, I still get two failures:

  • the docstring example
  • test_get_test_params_coverage (I think this is separately skipped in the block below)

fkiraly
fkiraly previously approved these changes Dec 29, 2024
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it now.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@fkiraly fkiraly changed the title [ENH] Remove binary segmentation tests from exclude list [ENH] BinarySegmentation fixes for new detection interface Dec 29, 2024
@fkiraly fkiraly merged commit 381610c into sktime:main Dec 29, 2024
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] Fix failing output tests for the BinarySegmentation detector
2 participants