[ENH] homogenization of sktime and skchange detection API - predict, predict_points, predict_segments
#7476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
implementing framework
fkiraly
requested review from
achieveordie,
benHeid,
fnhirwa,
geetu040,
pranavvp16,
XinyuWuu and
yarnabrina
as code owners
|
Looks good!
|
Yes, that's what I thought - although I would change this to |
Now is fine with me. |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR carries out some remaining steps of interface homogenization with
skchange:predict,predict_points,predict_segmentsis now always aRangeIndex- no key information requires index manipulation anymore.predict,predict_points,predict_segmentsis now always apd.DataFrame, with one column"ilocs"for the event indices, and additional potential columns in supervised and semi-supervised casespredictis now identical with one ofpredict_pointsorpredict_segmentsin the supervised and semi-supervised caseAlso updates some estimators to function as expected: