[DOC] Fixes Time Series Segmentation with sktime and ClaSP notebook example #7283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to api changes. It is no long possible to specify output formats, they are replaced with dense_to_sparse and sparse to dense methods. I replaced the examples near the end of the notebook to show how to use the methods, and removed all fmt parameters from the code cells.
RobotPsychologist
requested review from
achieveordie,
benHeid,
fkiraly,
fnhirwa,
geetu040,
pranavvp16,
XinyuWuu and
yarnabrina
as code owners
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
fkiraly
requested changes
Oct 17, 2024
There was a problem hiding this comment.
The linter complains, code formatting, see below.
For notebooks, this might be not as straightforward as usual, here is the guide:
https://www.sktime.net/en/latest/developer_guide/coding_standards.html#setting-up-local-code-quality-checks
fkiraly
approved these changes
Oct 17, 2024
fkiraly
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #7282
What does this implement/fix? Explain your changes.
This fixes minor documentation issues with the ClaSP Segmentation notebook.
Does your contribution introduce a new dependency? If yes, which one?
No.
What should a reviewer concentrate their feedback on?
Making sure the changes to the Output Format section are appropriate.
Did you add any tests for the change?
No tests required. This is a minor documentation fix.
Any other comments?
PR checklist
For all contributions
How to: add yourself to the all-contributors file in the
sktimeroot directory (not theCONTRIBUTORS.md). Common badges:code- fixing a bug, or adding code logic.doc- writing or improving documentation or docstrings.bug- reporting or diagnosing a bug (get this pluscodeif you also fixed the bug in the PR).maintenance- CI, test framework, release.See here for full badge reference
maintainerstag - do this if you want to become the owner or maintainer of an estimator you added.See here for further details on the algorithm maintainer role.
For new estimators
docs/source/api_reference/taskname.rst, follow the pattern.Examplessection.python_dependenciestag and ensureddependency isolation, see the estimator dependencies guide.