Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNT] Updating pre-commit hooks and corresponding changes #7109

Merged
merged 2 commits into from
Sep 14, 2024
Merged

[MNT] Updating pre-commit hooks and corresponding changes #7109

merged 2 commits into from
Sep 14, 2024

Conversation

yarnabrina
Copy link
Member

Maintenance only changes.

  1. pre-commit autoupdate
  2. pre-commit run --all-files

ruff detected a bunch of problems in different notebooks and solved most of them manually. Rest of them are done manually.

@yarnabrina yarnabrina added the maintenance Continuous integration, unit testing & package distribution label Sep 11, 2024
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@yarnabrina
Copy link
Member Author

@fkiraly It seems that most, if not all, examples for fracdiff notebooks do not even use sktime. Is it usual for those to be part of examples section in sktime repository?

@fkiraly
Copy link
Collaborator

fkiraly commented Sep 12, 2024

@fkiraly It seems that most, if not all, examples for fracdiff notebooks do not even use sktime. Is it usual for those to be part of examples section in sktime repository?

Hm, I did not notice this, I thought they were in an examples directory within fracdiff, but I suppose they were just lifted from the now defunct package, and put there as an easy way to ensure they run. Perhaps we should add a readme, or a link from the fracdiff readme, as the notebooks cannot be accessed through the webpage.

More generally, I am not sure where notebooks from vendor packages, especially those that are now "onboard" after being defunct, should go.

@yarnabrina yarnabrina merged commit 67acec5 into sktime:main Sep 14, 2024
17 checks passed
@yarnabrina yarnabrina deleted the pre-commit branch September 14, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkiraly fkiraly fkiraly approved these changes

@achieveordie achieveordie Awaiting requested review from achieveordie

@benHeid benHeid Awaiting requested review from benHeid benHeid is a code owner

Assignees
No one assigned
Labels
maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yarnabrina @fkiraly