Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] example & tutorial notebooks: normalize execution counts, indentation, execute all cells #6847

Merged
merged 6 commits into from
Jul 28, 2024

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Jul 26, 2024

This PR cleans up some inconsistencies in example and tutorial notebooks:

  • normalize execution counts, so cells are numbered with consecutively
  • execute all cells that were not executed
  • normalize indentations to json indent=1

@fkiraly fkiraly added the documentation Documentation & tutorials label Jul 26, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@yarnabrina yarnabrina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, assuming it's mostly "restart and run all cells" for all notebooks, plus adding few details.

(It's very difficult follow git diff of notebooks for me, is there a better way?)

@fkiraly
Copy link
Collaborator Author

fkiraly commented Jul 28, 2024

Approved, assuming it's mostly "restart and run all cells" for all notebooks, plus adding few details.

Yes, indeed, only restart and run and renumber.

(It's very difficult follow git diff of notebooks for me, is there a better way?)

The "notebook diff app" above is supposed to do this, but I do not find it that helpful.

@fkiraly fkiraly merged commit 3781b8c into main Jul 28, 2024
17 checks passed
@fkiraly fkiraly deleted the execution-counts branch July 28, 2024 18:27
fkiraly added a commit that referenced this pull request Aug 5, 2024
This PR adds a formatter for jupyter notebook json in build tools, used
for cleaning up the jupyter notebooks in
#6847.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation & tutorials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants