Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNT] Code quality updates #5786

Merged
merged 3 commits into from
Jan 22, 2024
Merged

[MNT] Code quality updates #5786

merged 3 commits into from
Jan 22, 2024

Conversation

yarnabrina
Copy link
Member

Automated changes from code quality tools, no manual changes.

  1. updated version of pre-commit hooks (pre-commit autoupdate)
  2. ran ruff with default settings (ruff sktime) -> ignored changes in sktime/_contrib
  3. ran all hooks on all files (pre-commit run --all-files) -> ignored changes in examples/blog_posts

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@yarnabrina
Copy link
Member Author

Notes for reviewers:

  1. examples/blog_posts/Overview_of_sktime_functionalities_for_forecasting.ipynb has completely failed pre-commit checks, as reported in [DOC] Code quallity check fails for examples/blog_posts/Overview_of_sktime_functionalities_for_forecasting.ipynb #5683. Since it was suggested there to keep it as it is, ignored in this PR.

  2. sktime/_contrib showed a lot of commented codes, unused imports, unused variables, etc. Those looked like interactive notebook codes converted to scripts. I am not sure of the intent of these files, so kept as it is if they are used as references or examples somewhere else.

fkiraly
fkiraly approved these changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fkiraly fkiraly merged commit da59816 into sktime:main Jan 22, 2024
99 checks passed
@yarnabrina yarnabrina deleted the code-quality branch January 23, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkiraly fkiraly fkiraly approved these changes

@achieveordie achieveordie Awaiting requested review from achieveordie

@benHeid benHeid Awaiting requested review from benHeid benHeid is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yarnabrina @fkiraly