[ENH] Add calibration_plot for probabilistic forecasts
#5632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benHeid
requested review from
achieveordie,
fkiraly and
yarnabrina
as code owners
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
fkiraly
reviewed
Dec 18, 2023
fkiraly
reviewed
Dec 18, 2023
sktime/utils/plotting.py
Outdated
|
|
||
| Parameters | ||
| ---------- | ||
| y_true : pd.Series |
There was a problem hiding this comment.
could also be single-series iterable, e.g., 1-column pd.DataFrame etc?
There was a problem hiding this comment.
Yes also possible are single columned pd.DataFrames and np.arrays
There was a problem hiding this comment.
so the docstrig should say so, no?
TODO
|
benHeid
force-pushed
the
calibration_plot
branch
from
70dfb47 to
c33d935
Compare
fkiraly
requested changes
Dec 19, 2023
fkiraly
changed the title
calibration_plotmethodcalibration_plot for probabilistic forecasts
fkiraly
added
module:forecasting
fkiraly
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
fixes #5631
What does this implement/fix? Explain your changes.
This implements a method to create calibration plots and adds an example in the probabilistic forecasting notebook.
Did you add any tests for the change?
I would appreciate feedback on how testing of plot functionalities should look like
PR checklist
For all contributions
How to: add yourself to the all-contributors file in the
sktimeroot directory (not theCONTRIBUTORS.md). Common badges:code- fixing a bug, or adding code logic.doc- writing or improving documentation or docstrings.bug- reporting or diagnosing a bug (get this pluscodeif you also fixed the bug in the PR).maintenance- CI, test framework, release.See here for full badge reference
See here for further details on the algorithm maintainer role.